Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Absolute import of Result in derive #2587

Merged
merged 3 commits into from
Sep 30, 2021

Conversation

ureeves
Copy link
Contributor

@ureeves ureeves commented Sep 28, 2021

Description

When aliasing Result deriving WasmerEnv is not possible. See a minimal example of the problem below.

use wasmer::WasmerEnv;

struct Error;
type Result<T> = core::result::Result<T, Error>;

#[derive(WasmerEnv, Clone)]
struct MyEnv; // error[E0107] this type alias takes 1 generic
              // argument but 2 generic arguments were supplied

Review

  • Add a short description of the change to the CHANGELOG.md file

@syrusakbary
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Sep 29, 2021
2587: Absolute import of `Result` in derive r=syrusakbary a=ureeves

# Description

When aliasing `Result` deriving `WasmerEnv` is not possible. See a minimal example of the problem below.

```rust
use wasmer::WasmerEnv;

struct Error;
type Result<T> = core::result::Result<T, Error>;

#[derive(WasmerEnv, Clone)]
struct MyEnv; // error[E0107] this type alias takes 1 generic
              // argument but 2 generic arguments were supplied
```

# Review

- [x] Add a short description of the change to the CHANGELOG.md file


Co-authored-by: Eduardo Leegwater Simões <[email protected]>
@bors
Copy link
Contributor

bors bot commented Sep 29, 2021

Build failed:

@ureeves
Copy link
Contributor Author

ureeves commented Sep 30, 2021

I'm not sure these changes could have caused this @syrusakbary. Anything I can do?

@syrusakbary
Copy link
Member

We are aware there are some flaky tests, which seems to be causing the issue.
As we will fix them in master we can merge this PR

@syrusakbary syrusakbary merged commit d287670 into wasmerio:master Sep 30, 2021
@syrusakbary syrusakbary added this to the v2.1 milestone Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants